Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Producer] check if message is nil #1047

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jul 4, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Check if a message is nil before accessing it in partitionProducer.internalSendAsync()

Modifications

  • pulsar/producer_partition.go
  • pulsar/producer_test.go

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@shibd shibd merged commit 8d45137 into apache:master Jul 6, 2023
@BewareMyPower BewareMyPower added this to the v0.12.0 milestone Jul 7, 2023
RobertIndie pushed a commit that referenced this pull request Sep 7, 2023
* [Fix][Producer] check if message is nil

* add a debug log

---------

Co-authored-by: gunli <gunli@tencent.com>
(cherry picked from commit 8d45137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants