-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace license header checker and formatter #1077
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
As an administrative note now that we have an actual PR, I am prepped to replay the changes from streamnative/pulsar-admin-go#41 on top of these changes to refactor the API, either as a PR on this branch branch, against master, or as a separate PR, whichever is most appropriate. See #1075 for context. I would then begin the work of merging auth functionality and creating an admin client type. This would remove the Thus, type Client interface {
Functions() Functions
// ...
} would become: type Client interface {
Functions() *FunctionsWorker
// ...
}
// or
type Client struct{
// internal fields
Functions *FunctionsWorker
//etc
} I lean towards the concrete type if I'm being honest, since the construction of calling type MyFunctionMaintainer struct {
functionAPI functionAPI
}
type functionAPI interface {
CreateFuncWithURL(data *utils.FunctionConfig, pkgURL string) error
GetFunction(tenant, namespace, name string) (utils.FunctionConfig, error)
UpdateFunction(functionConfig *utils.FunctionConfig, fileName string, updateOptions *utils.UpdateOptions) error
DeleteFunction(tenant, namespace, name string) error
} A further PR could integrate the admin client into the normal pulsar tests, providing a single place to access the integration container, removing some of the awkward constructions used in #1076 and using the test admin client as the single point of access controlling the spawning of the integration container. Which would be awesome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can this PR include the pulsar-go-admin commit?
That's possible. Let me prepare a patch for this requirement. We should be able to use git filter-repo/filter-branch for such case. |
I'd minimize the changeset to replace the license checker in this PR and prepare a new one to do the filter-branch work which can be much more complicated. |
Signed-off-by: tison <wander4096@gmail.com>
This refers to #1075.
Roughly add source code with ASF header without any nontrivial changes.
cc @flowchartsman @Gleiphir2769 @gunli