[Issue 1274][connection] Refactor connection concurrency model #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilthoniel
force-pushed
the
feature/connection-concurrency
branch
from
20c03e2
to
f24f7c7
Compare
nodece
approved these changes
Sep 5, 2024
lhotari
requested review from
RobertIndie,
BewareMyPower,
heesung-sn,
crossoverJie,
shibd and
poorbarcode
crossoverJie
approved these changes
Sep 11, 2024
|
@Gilthoniel Thanks for this fix. Was this issue introduced in CC: @crossoverJie @nodece |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1274
Motivation
A race can happen while a consumer or a producer is registering itself to the connection to later receive closing notification.
Modifications
This pull request changes the concurrency model of the connection to properly lock the different actors between the closing procedure and the registration of handlers and listeners. After this, a caller will properly check the state of the connection and aborts if closed, and it will be certain that it will not be registered in concurrency with a closing.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
none
Documentation
none