Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1262][consumer] stop timer when close timedAckGroupingTracker #1279

Merged

Conversation

geniusjoe
Copy link
Contributor

@geniusjoe geniusjoe commented Sep 3, 2024

Contribution Checklist

Fixes #1262

Motivation

According to #1262

The ticker.Stop method is never called on the timedAckGroupingTracker member ticker, and so it is leaked.

Modifications

Call t.ticker.Stop() function when close timedAckGroupingTracker.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added integration tests

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@geniusjoe geniusjoe changed the title [Issue 1276][consumer] stop timer when close timedAckGroupingTracker [Issue 1262][consumer] stop timer when close timedAckGroupingTracker Sep 4, 2024
@nodece nodece added this to the v0.14.0 milestone Sep 4, 2024
@nodece nodece merged commit be55314 into apache:master Sep 4, 2024
7 checks passed
@geniusjoe geniusjoe deleted the dev/release-grouping-ack-tracker-timer branch September 9, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readers leak timers when closed
2 participants