Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1282][test] use pulsar-client-go-test docker to test TestBlueGreenMigrationTestSuite case #1287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geniusjoe
Copy link
Contributor

Contribution Checklist

Issue #1282

Motivation

Use pulsar-client-go-test docker to test TestBlueGreenMigrationTestSuite case, so that we can get rid of local environment go pkg dependencies.

Modifications

  1. Use integration-tests/extensible-load-manager/docker-compose.yml docker network in integration-tests/blue-green/docker-compose.yml green cluster, to make sure two clusters are in the same network environment.
  2. Use new unique service names in integration-tests/blue-green/docker-compose.yml green cluster to avoid service name duplication.
  3. Use service name instead of service forwarding port in pulsar/blue_green_migration_test.go.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Updated integration tests

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@geniusjoe geniusjoe marked this pull request as draft September 23, 2024 07:11
@geniusjoe geniusjoe force-pushed the dev/blue-green-docker-test branch 2 times, most recently from 6a771f3 to 5b48fd3 Compare September 23, 2024 18:34
@geniusjoe geniusjoe marked this pull request as ready for review September 24, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant