Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single partition router #999

Merged
merged 10 commits into from
Jun 28, 2023
32 changes: 32 additions & 0 deletions pulsar/producer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,38 @@ func TestMessageRouter(t *testing.T) {
assert.NotNil(t, msg)
assert.Equal(t, string(msg.Payload()), "hello")
}
func TestMessageSingleRouter(t *testing.T) {
// Create topic with 5 partitions
topicAdminURL := "admin/v2/persistent/public/default/my-single-partitioned-topic/partitions"
err := httpPut(topicAdminURL, 5)
defer httpDelete(topicAdminURL)
if err != nil {
t.Fatal(err)
}
client, err := NewClient(ClientOptions{
URL: serviceURL,
})

assert.Nil(t, err)
defer client.Close()

producer, err := client.CreateProducer(ProducerOptions{
Topic: "my-single-partitioned-topic",
MessageRouter: NewSinglePartitionRouter(),
})

assert.Nil(t, err)
defer producer.Close()

ctx := context.Background()

ID, err := producer.Send(ctx, &ProducerMessage{
Payload: []byte("hello"),
})
assert.Nil(t, err)
assert.NotNil(t, ID)

shibd marked this conversation as resolved.
Show resolved Hide resolved
}

func TestNonPersistentTopic(t *testing.T) {
topicName := "non-persistent://public/default/testNonPersistentTopic"
Expand Down
42 changes: 42 additions & 0 deletions pulsar/single_partition_router.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package pulsar

import "sync"

func NewSinglePartitionRouter() func(*ProducerMessage, TopicMetadata) int {
var (
singlePartition *int
once sync.Once
)
return func(message *ProducerMessage, metadata TopicMetadata) int {
nodece marked this conversation as resolved.
Show resolved Hide resolved
numPartitions := metadata.NumPartitions()
if len(message.Key) != 0 {
// When a key is specified, use the hash of that key
return int(getHashingFunction(JavaStringHash)(message.Key) % numPartitions)
}
once.Do(func() {
partition := r.R.Intn(int(numPartitions))
singlePartition = &partition
})

return *singlePartition

}

}
62 changes: 62 additions & 0 deletions pulsar/single_partition_router_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package pulsar

import (
"testing"

"github.com/stretchr/testify/assert"
)

type topicMetaData struct {
partition uint32
}

func (t topicMetaData) NumPartitions() uint32 {
return t.partition
}

func TestNewSinglePartitionRouter(t *testing.T) {
numPartitions := topicMetaData{2}
router := NewSinglePartitionRouter()
p := router(&ProducerMessage{
Payload: []byte("message 2"),
}, numPartitions)
assert.GreaterOrEqual(t, p, 0)

p2 := router(&ProducerMessage{
Payload: []byte("message 2"),
}, numPartitions)
assert.Equal(t, p, p2)
}

func TestNewSinglePartitionRouterWithKey(t *testing.T) {
router := NewSinglePartitionRouter()
numPartitions := topicMetaData{3}
p := router(&ProducerMessage{
Payload: []byte("message 2"),
Key: "my-key",
}, numPartitions)
assert.Equal(t, 1, p)

p2 := router(&ProducerMessage{
Key: "my-key",
Payload: []byte("message 2"),
}, numPartitions)
assert.Equal(t, p, p2)
}