-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Upgrade json-smart to 2.5.2 #23966
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
9999069
to
e30ff5c
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23966 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
+ Complexity 32624 31887 -737
============================================
Files 1877 1853 -24
Lines 139502 143820 +4318
Branches 15299 16337 +1038
============================================
+ Hits 102638 106769 +4131
+ Misses 28908 28666 -242
- Partials 7956 8385 +429
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 3cc2206) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 3cc2206)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 3cc2206)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 3cc2206)
Motivation
Build error on the branch-3.0:
Build error on master:
This is a bug: netplex/json-smart-v2#240
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete