Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Upgrade json-smart to 2.5.2 #23966

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

nodece
Copy link
Member

@nodece nodece commented Feb 12, 2025

Motivation

Build error on the branch-3.0:

$ mvn install -Pcore-modules,-main -DskipTests -Dspotbugs.skip=true -T 1C

Caused by: org.eclipse.aether.collection.DependencyCollectionException: Failed to collect dependencies at org.apache.kerby:kerb-simplekdc:jar:1.1.1 -> org.apache.kerby:kerb-client:jar:1.1.1 -> org.apache.kerby:token-provider:jar:1.1.1 -> com.nimbusds:nimbus-jose-jwt:jar:4.41.2 -> net.minidev:json-smart:jar:[1.3.1,2.3]

Build error on master:

Error:  Failed to execute goal on project pulsar-io-azuredataexplorer: Could not collect dependencies for project org.apache.pulsar:pulsar-io-azuredataexplorer:jar:4.1.0-SNAPSHOT
Error:  No versions available for net.minidev:json-smart:jar:[1.3.3,2.4.10] within specified range
Error:  No versions available for net.minidev:json-smart:jar:[1.3.1,2.3] within specified range
Error:  No versions available for net.minidev:json-smart:jar:[1.3.1,2.3] within specified range
Error:  No versions available for net.minidev:json-smart:jar:[1.3.1,2.3] within specified range
Error:  No versions available for net.minidev:json-smart:jar:[1.3.1,2.3] within specified range
Error:  No versions available for net.minidev:json-smart:jar:[1.3.1,2.3] within specified range

This is a bug: netplex/json-smart-v2#240

Modifications

  • Upgrade json-smart to 2.5.2 from 2.4.10

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece added this to the 4.1.0 milestone Feb 12, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece changed the title [fix][build] Upgrade kerby to 2.1.0 [fix][build] Upgrade json-smart to 2.5.1 Feb 12, 2025
@hezhangjian
Copy link
Member

2.5.2 is better, and I'm involved in this release. Still investigating why this went wrong.
netplex/json-smart-v2#240

@nodece nodece changed the title [fix][build] Upgrade json-smart to 2.5.1 [fix][build] Upgrade json-smart to 2.5.2 Feb 12, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (bbc6224) to head (eacecd7).
Report is 901 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23966      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.66%     
+ Complexity    32624    31887     -737     
============================================
  Files          1877     1853      -24     
  Lines        139502   143820    +4318     
  Branches      15299    16337    +1038     
============================================
+ Hits         102638   106769    +4131     
+ Misses        28908    28666     -242     
- Partials       7956     8385     +429     
Flag Coverage Δ
inttests 26.81% <ø> (+2.22%) ⬆️
systests 23.24% <ø> (-1.09%) ⬇️
unittests 73.74% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1042 files with indirect coverage changes

@nodece nodece merged commit 3cc2206 into apache:master Feb 12, 2025
56 of 58 checks passed
nodece added a commit to ascentstream/pulsar that referenced this pull request Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

(cherry picked from commit 3cc2206)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece deleted the upgrade-kerby branch February 12, 2025 15:09
lhotari pushed a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 3cc2206)
lhotari pushed a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 3cc2206)
lhotari pushed a commit that referenced this pull request Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 3cc2206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants