Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Update TypedMessageBuilder deliverAfter and deliverAt api comment #23969

Conversation

geniusjoe
Copy link
Contributor

Fixes #23968

Motivation

Related Issue: apache/pulsar-site#507

We now support consuming delayed messages with shared and Key-shared type subscriptions, which has been corrected since pulsar 3.x doc in above pr.

But Java code deliverAt and deliverAfter comment says we can only support Shared type subscription, so that maybe we need to fix them.

Modifications

Replace {@link SubscriptionType#Shared} comment with {@link SubscriptionType#Shared} or {@link SubscriptionType#Key_Shared} in deliverAt and deliverAfter api.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 12, 2025
@geniusjoe
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (bbc6224) to head (d7d6355).
Report is 917 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23969      +/-   ##
============================================
+ Coverage     73.57%   74.21%   +0.63%     
+ Complexity    32624    32263     -361     
============================================
  Files          1877     1853      -24     
  Lines        139502   143820    +4318     
  Branches      15299    16337    +1038     
============================================
+ Hits         102638   106731    +4093     
+ Misses        28908    28699     -209     
- Partials       7956     8390     +434     
Flag Coverage Δ
inttests 26.85% <ø> (+2.27%) ⬆️
systests 23.21% <ø> (-1.12%) ⬇️
unittests 73.74% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1042 files with indirect coverage changes

@merlimat merlimat added this to the 4.1.0 milestone Feb 13, 2025
@merlimat merlimat merged commit ee5b13a into apache:master Feb 13, 2025
61 checks passed
merlimat pushed a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TypedMessageBuilder deliverAfter and deliverAt api comment
3 participants