Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][meta] Fix ephemeral Zookeeper put which creates a persistent znode #23984

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Feb 13, 2025

Fixes #23889

Motivation

Fixes #23889
zk.put creates persistent znode although it passes ephemeral node creation option.

Modifications

  • pass the creation option when set fails(if the node exists already

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: heesung-sn#87

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 13, 2025
@heesung-sn
Copy link
Contributor Author

heesung-sn commented Feb 13, 2025

This PR does not include the zk.Stat ephemral check fix, since #23902 (fix zkStat.getEphemeralOwner() != 0) requires more work to update test framework.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member

lhotari commented Feb 14, 2025

This PR does not include the zk.Stat ephemral check fix, since #23902 (fix zkStat.getEphemeralOwner() != 0) requires more work to update test framework.

Thank you @heesung-sn. Makes sense to split things into multiple PRs. The test framework changes are actually completed, I'll push a PR with those. It's possible that we have many bad tests which were relying on the wrong assumptions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (bbc6224) to head (4255386).
Report is 913 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23984      +/-   ##
============================================
+ Coverage     73.57%   74.19%   +0.62%     
+ Complexity    32624    31881     -743     
============================================
  Files          1877     1853      -24     
  Lines        139502   143826    +4324     
  Branches      15299    16337    +1038     
============================================
+ Hits         102638   106715    +4077     
+ Misses        28908    28727     -181     
- Partials       7956     8384     +428     
Flag Coverage Δ
inttests 26.86% <100.00%> (+2.28%) ⬆️
systests 23.24% <100.00%> (-1.09%) ⬇️
unittests 73.70% <100.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/metadata/impl/ZKMetadataStore.java 85.53% <100.00%> (+0.28%) ⬆️

... and 1042 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata information is not cleaned when broker exits abnormally
3 participants