-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][meta] Fix ephemeral Zookeeper put which creates a persistent znode #23984
Conversation
This PR does not include the zk.Stat ephemral check fix, since #23902 (fix zkStat.getEphemeralOwner() != 0) requires more work to update test framework. |
ef507ea
to
4255386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @heesung-sn. Makes sense to split things into multiple PRs. The test framework changes are actually completed, I'll push a PR with those. It's possible that we have many bad tests which were relying on the wrong assumptions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23984 +/- ##
============================================
+ Coverage 73.57% 74.19% +0.62%
+ Complexity 32624 31881 -743
============================================
Files 1877 1853 -24
Lines 139502 143826 +4324
Branches 15299 16337 +1038
============================================
+ Hits 102638 106715 +4077
+ Misses 28908 28727 -181
- Partials 7956 8384 +428
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #23889
Motivation
Fixes #23889
zk.put creates persistent znode although it passes ephemeral node creation option.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: heesung-sn#87