[improve][ci] Upgrade Gradle Develocity Maven Extension to 1.23.1 #24004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clayburn Do you have a chance to check the deadlock details available in the issue description which contains references to Gradle Develocity Maven Extension? |
|
@clayburn Another similar deadlock in https://github.com/apache/pulsar/actions/runs/13410108649/job/37458643828#step:13:794. Do you know if this is fixed with com.gradle:develocity-maven-extension:1.23.1 ? |
|
Found Develocity Maven Extension release notes at https://docs.gradle.com/develocity/maven-extension/current/#release_history . There doesn't seem to be recent deadlock fixes. |
|
Thanks for raising this. I'm not aware of any fix in 1.23.1, so we will investigate and come back to you. |
|
The problem seems to consistently reproduce. For example it failed in the build of this PR: https://github.com/apache/pulsar/actions/runs/13413883514/job/37470450862?pr=24004#step:13:857 |
|
Since Testcontainers seems to always be part of the stack traces, I have a PR to upgrade to latest Testcontainers version in #24003, just to rule out any known issues related to Testcontainers that are fixed in latest. |
nodece
approved these changes
Feb 20, 2025
dao-jun
approved these changes
Feb 20, 2025
|
@lhotari , I looked into this issue on the Develocity Maven extension side. I think I have something that we can try to prevent the deadlock from happening. When your build is running, we capture info about the TestNG tests as they start. If the test uses a At the same time, we see that some other thread is already executing Is there any way to simplify this parameter name supplier to not invoke the Testcontainers API (the I am not 100% sure that it will help. For the sake of experiments, you could set it to some dumb value and see if the deadlock still happens at the same place. The deadlock stacktrace will point to the parameter value that causes it. It can happen that there are other parameter values that will cause the deadlock. Let us know if this helps. |
Thank you for pointing out the problem, @pshevche. I'll make changes in the test class to address the issue so that the particular |
…tion when toString is called
|
Workaround applied in 51563a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar, we use ASF hosted Gradle Delocity for analysing Pulsar's maven builds.
Example listing of latest builds: https://develocity.apache.org/scans?search.rootProjectNames=Pulsar
There was a deadlock in https://github.com/apache/pulsar/actions/runs/13410107140/job/37458613913#step:13:1612 which could be caused by Gradle Develocity Maven Extension. The currently used version is 1.22.2 . Since there's a newer version available, it's worth upgrading to see if it resolves the issue in future builds.
Modifications
Upgrade
org.gradle:develocity-maven-extensionin.mvn/extensions.xmlto 1.23.1Documentation
docdoc-requireddoc-not-neededdoc-complete