[fix][broker] Fix totalAvailablePermits not reduced when removing consumer from non-persistent dispatcher #24885
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
NonPersistentDispatcherMultipleConsumersremoves a consumer via theremoveConsumer()method, theTOTAL_AVAILABLE_PERMITS_UPDATERis not properly decremented when there are multiple consumers (consumers' size > 1). This creates an inconsistency where the dispatcher maintains an inflated count of available permits after consumer removalModifications
Added logic in
NonPersistentDispatcherMultipleConsumers.removeConsumer()to properly decrementTOTAL_AVAILABLE_PERMITS_UPDATERby the removed consumer's available permits when consumers' size > 1Added test case
testTotalAvailablePermitsWhenRemoveConsumer()to verify:Initial permit counting works correctly
Permit reduction happens properly when removing consumers
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#28