RANGER-5369: introduce inline-policy to support service-managed ACLs #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
Copilot,
kulkabhay,
kumaab,
pradeepagrawal8184,
rameeshm,
spolavarpau1 and
vperiasamy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for RangerInlinePolicy to enable service-managed ACLs alongside Ranger policies. The implementation adds a new policy evaluation mechanism that allows services to authorize access based on ACLs they manage directly, with configurable modes for combining Ranger and inline policy decisions.
Key changes:
- Added
RangerInlinePolicymodel with support for grants, resources, and permissions - Implemented
RangerInlinePolicyEvaluatorto evaluate inline policies during access requests - Extended the policy engine to support inline policy evaluation with three modes: INLINE, RANGER_AND_INLINE, and RANGER_OR_INLINE
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| authz-api/src/main/java/org/apache/ranger/authz/util/RangerResourceNameParser.java | Made resource separator character configurable to support flexible resource naming |
| agents-common/src/main/java/org/apache/ranger/plugin/model/RangerInlinePolicy.java | New model class defining inline policy structure with grants, modes, and permissions |
| agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerInlinePolicyEvaluator.java | New evaluator implementing inline policy authorization logic |
| agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java | Integrated inline policy evaluation into the main policy engine flow |
| agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java | Added configuration option for customizable resource separator character |
| agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java | Extended to support resource parsing and RRN template generation with configurable separator |
| agents-common/src/test/resources/policyevaluator/test_inline_policies_ozone.json | Test data covering various inline policy scenarios for Ozone service |
| distro/src/main/assembly/*.xml | Added ranger-authz-api dependency to all distribution assemblies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...mmon/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerInlinePolicyEvaluator.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update Ranger policy engine to support
RangerInlinePolicy, which can be used to authorize access to resources based on ACLs managed by services, in addition to Ranger policies.How was this patch tested?
Added unit tests.