fix(utils): Fix file backup logic in WriteToFile and enhance test coverage #1199
+144
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In the internal/utils/files.go package, the WriteToFile function failed to properly backup existing file contents when overwriting files. Specifically:
When writing to an existing path (e.g., aaa/exist.txt), the function only create a backup file (aaa/exist.txt.bak) before overwriting, but write nothing, leading to potential data loss.
Existing test cases lacked coverage for backup logic and related file utility functions.
Brief changelog
internal/utils/files.go:WriteToFile
internal/utils/files_test.go
internal/utils/set_test.go
Verifying this change
see test file
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.