Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add producer stats manager #9165

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HScarb
Copy link
Contributor

@HScarb HScarb commented Feb 4, 2025

Which Issue(s) This PR Fixes

Fixes #9164

Brief Description

Add a producer stats manager to the 4.x Java client to periodically print produce stats in the client logs.

How Did You Test This Change?

Running 4.x java client's producer benchmark and checking for the logs.

image

@yx9o
Copy link
Contributor

yx9o commented Feb 5, 2025

Hi, I think it is enough to monitor the time taken to call the sending API directly in the application. There is no need to integrate it into the sending client.

@HScarb HScarb force-pushed the feat/produce-stats branch 3 times, most recently from 79fe376 to 9539b04 Compare February 7, 2025 16:02
@HScarb HScarb force-pushed the feat/produce-stats branch from 9539b04 to 2e70aaf Compare February 7, 2025 16:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.43478% with 32 lines in your changes missing coverage. Please review.

Project coverage is 48.01%. Comparing base (a3afb05) to head (2e70aaf).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 25.92% 15 Missing and 5 partials ⚠️
...che/rocketmq/client/stat/ProducerStatsManager.java 35.29% 11 Missing ⚠️
...rocketmq/client/impl/factory/MQClientInstance.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9165      +/-   ##
=============================================
- Coverage      48.04%   48.01%   -0.03%     
- Complexity     12064    12084      +20     
=============================================
  Files           1320     1322       +2     
  Lines          92824    93080     +256     
  Branches       11897    11931      +34     
=============================================
+ Hits           44596    44693      +97     
- Misses         42734    42849     +115     
- Partials        5494     5538      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add producer stats manager for 4.x java client
3 participants