Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement one-time-salt use and add comprehensive tests #142

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

snoopdave
Copy link
Contributor

@snoopdave snoopdave commented Oct 5, 2024

This PR implements one-time use salts, improves URL matching for ignored URLs, and enhances security in ValidateSaltFilter and LoadSaltFilter. It also adds comprehensive unit tests for both filters to ensure proper functionality and edge case handling. The changes include:

  • Implementing one-time use salts by removing them from the cache after validation
  • Improving URL matching to consider full URLs including query parameters
  • Enhancing security checks in ValidateSaltFilter
  • Adding robust unit tests for both filters
  • Refactoring code for better readability and maintainability

@snoopdave snoopdave requested a review from mbien October 5, 2024 20:45
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@snoopdave snoopdave merged commit faafe37 into master Oct 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants