Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roller session improvements #147

Closed
wants to merge 11 commits into from
Closed

Roller session improvements #147

wants to merge 11 commits into from

Conversation

snoopdave
Copy link
Contributor

@snoopdave snoopdave commented Jan 18, 2025 •
edited
Loading

This PR enhances session security by properly invalidating user sessions when administrators change user attributes.

Key Changes

  • Added RollerSessionManager to track and invalidate sessions
  • Created UIBeanFactory to standardize Struts 2 bean creation
  • Updated UserEdit to invalidate affected user sessions
  • Added comprehensive test coverage

Implementation Details

  • RollerSessionManager provides centralized session cache
  • UIBeanFactory manages consistent bean creation across UI layer
  • Extensive changes were needed to retrofit session management for proper dependency injection

@snoopdave
Copy link
Contributor Author

I think this PR has gotten too complicated at I should revert it back to the first commit.

@snoopdave
Copy link
Contributor Author

This PR works and might be considered an improvement, but I think this one is a better fix because it involves less changes: #148

@snoopdave snoopdave closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snoopdave