Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-2757 : Make Samza Compatible with Java 11 #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions README-gradle.md

This file was deleted.

11 changes: 8 additions & 3 deletions bin/grid
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ DEPLOY_ROOT_DIR=$BASE_DIR/deploy
DOWNLOAD_CACHE_DIR=$HOME/.samza/download
COMMAND=$1
SYSTEM=$2
YARN_VERSION="3.3.4"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be flagged somehow to correspond with the version of Java being used, or maybe intentionally flagged? I believe Samza under Java 8 is still using Hadoop 2.10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that using Java8 still works with this setup (meaning 3.3.4). So this whole system still works if you are running Java 8, It's just that this newer setup (if you use Samza 1.8.0) now works with Java 11.


DOWNLOAD_KAFKA=https://archive.apache.org/dist/kafka/2.1.1/kafka_2.11-2.1.1.tgz
DOWNLOAD_YARN=https://archive.apache.org/dist/hadoop/common/hadoop-2.9.2/hadoop-2.9.2.tar.gz
DOWNLOAD_YARN=https://archive.apache.org/dist/hadoop/common/hadoop-$YARN_VERSION/hadoop-$YARN_VERSION.tar.gz
DOWNLOAD_ZOOKEEPER=https://archive.apache.org/dist/zookeeper/zookeeper-3.4.14/zookeeper-3.4.14.tar.gz

SERVICE_WAIT_TIMEOUT_SEC=20
Expand All @@ -52,6 +53,7 @@ bootstrap() {
mkdir "$DEPLOY_ROOT_DIR"
install_all
start_all
echo "Visit http://localhost:8088/ for Hadoop UI"
exit 0
}

Expand Down Expand Up @@ -81,17 +83,20 @@ install_all_without_yarn() {
install_samza() {
echo "Building samza from master..."
mkdir -p "$DEPLOY_ROOT_DIR"
echo "DOWNLOAD_CACHE_DIR: $DOWNLOAD_CACHE_DIR"
if [ -d "$DOWNLOAD_CACHE_DIR/samza/.git" ]; then
echo "Resetting local samza to master"
pushd "$DOWNLOAD_CACHE_DIR/samza"
git fetch origin
git reset --hard origin/master
else
echo "Cloning samza git repo to build locally"
mkdir -p $DOWNLOAD_CACHE_DIR
pushd $DOWNLOAD_CACHE_DIR
git clone https://gitbox.apache.org/repos/asf/samza.git
cd samza
fi
./gradlew -PscalaSuffix=2.11 clean publishToMavenLocal
./gradlew -PscalaSuffix=2.12 clean publishToMavenLocal
popd
}

Expand All @@ -103,7 +108,7 @@ install_zookeeper() {

install_yarn() {
mkdir -p "$DEPLOY_ROOT_DIR"
install yarn $DOWNLOAD_YARN hadoop-2.9.2
install yarn $DOWNLOAD_YARN hadoop-$YARN_VERSION
cp "$BASE_DIR/conf/yarn-site.xml" "$DEPLOY_ROOT_DIR/yarn/etc/hadoop/yarn-site.xml"
if [ ! -f "$HOME/.samza/conf/yarn-site.xml" ]; then
mkdir -p "$HOME/.samza/conf"
Expand Down
227 changes: 0 additions & 227 deletions build.gradle

This file was deleted.

25 changes: 0 additions & 25 deletions gradle.properties

This file was deleted.

Binary file removed gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
6 changes: 0 additions & 6 deletions gradle/wrapper/gradle-wrapper.properties

This file was deleted.

Loading