Skip to content

Commit

Permalink
Update api.py (#20)
Browse files Browse the repository at this point in the history
fix(client): fix the logical and login URL path errors for the registry namespace ID
- Fix the login URL path errors
- Change the original bitwise OR operator "|" to the logical OR operator "or"- This change ensures that SYS_DEFAULT_NAMESPACE_ID is used only when register_namespace_id is None or empty
- Previously, the use of the bitwise OR operator may have caused the default value to be used incorrectly when register_namespace_id was 0
  • Loading branch information
titxue authored Nov 20, 2024
1 parent fe0d9f6 commit f42dc04
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions client/apache_shenyu_client/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def _setup_register_params(self):
self.register_base_servers = GatewayConfig.register.get("servers").split(",")
self.register_namespace_id = GatewayConfig.register.get("namespace_id")
self.register_path = "/platform/login"
self.register_token_servers = [_url + self.register_uri_suffix for _url in self.register_base_servers]
self.register_token_servers = [_url + self.register_path for _url in self.register_base_servers]
self.register_username = GatewayConfig.register.get("props", {}).get("username")
self.register_password = GatewayConfig.register.get("props", {}).get("password")
except SetUpRegisterExp as se:
Expand Down Expand Up @@ -181,7 +181,7 @@ def register_uri(self):
"appName": self.app_name,
"contextPath": self.context_path,
"rpcType": self.rpc_type,
"namespaceId": self.register_namespace_id | self.SYS_DEFAULT_NAMESPACE_ID,
"namespaceId": self.register_namespace_id or self.SYS_DEFAULT_NAMESPACE_ID,
"host": self.host,
"port": self.port
}
Expand Down Expand Up @@ -226,7 +226,7 @@ def register_metadata(self, **kwargs):
json_data = {
"appName": self.app_name,
"contextPath": self.context_path,
"namespaceId": self.register_namespace_id | self.SYS_DEFAULT_NAMESPACE_ID,
"namespaceId": self.register_namespace_id or self.SYS_DEFAULT_NAMESPACE_ID,
"path": path,
"pathDesc": path_desc,
"rpcType": self.rpc_type,
Expand Down

0 comments on commit f42dc04

Please sign in to comment.