[SPARK-48754] Address comments (#31)

apache · Jul 9, 2024 · e0cde67 · e0cde67
1 parent a1b4f12
commit e0cde67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/spark/client/channel/channel.go b/spark/client/channel/channel.go
@@ -62,23 +62,23 @@ type BaseBuilder struct {
 	headers map[string]string
 }
 
-func (cb BaseBuilder) Host() string {
+func (cb *BaseBuilder) Host() string {
 	return cb.host
 }
 
-func (cb BaseBuilder) Port() int {
+func (cb *BaseBuilder) Port() int {
 	return cb.port
 }
 
-func (cb BaseBuilder) Token() string {
+func (cb *BaseBuilder) Token() string {
 	return cb.token
 }
 
-func (cb BaseBuilder) User() string {
+func (cb *BaseBuilder) User() string {
 	return cb.user
 }
 
-func (cb BaseBuilder) Headers() map[string]string {
+func (cb *BaseBuilder) Headers() map[string]string {
 	return cb.headers
 }
 

diff --git a/spark/sql/session/sparksession.go b/spark/sql/session/sparksession.go
@@ -51,7 +51,7 @@ func (s *SparkSessionBuilder) Remote(connectionString string) *SparkSessionBuild
 	return s
 }
 
-func (s *SparkSessionBuilder) ChannelBuilder(cb channel.Builder) *SparkSessionBuilder {
+func (s *SparkSessionBuilder) WithChannelBuilder(cb channel.Builder) *SparkSessionBuilder {
 	s.channelBuilder = cb
 	return s
 }