[SPARK-48777][BUILD]Migrate build system to Bazel #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundprinzip
changed the title
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Jul 3, 2024
|
Merged to master |
|
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 3, 2024
…owed and it follows the Spark release ### What changes were proposed in this pull request? Cleanup from #23 that needs to set the package version to something that is not v1. ### Why are the changes needed? Go compatibility ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests. Closes #24 from grundprinzip/SPARK-48777-2. Authored-by: Martin Grund <martin.grund@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Until now the repository was using a hand-written Makefile to compile and build the Spark Connect go client. This comes with some downsides of how to generate for example the protobuf and grpc dependencies and required us to commit the generated code to the repository.
This patch fixes this by migrating the build to Bazel and leveraging the built-in protobuf generation.
Why are the changes needed?
Build stability
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Existing Tests