fix: add unit tests to Row #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elbehery
force-pushed
the
76_test_row
branch
2 times, most recently
from
bf8753f
to
5b5dbc6
Compare
grundprinzip
approved these changes
Oct 21, 2024
spark/sql/types/row.go
Outdated
| @@ -46,7 +59,7 @@ func (r *rowImpl) Len() int { | |||
| } | |||
|
|
|||
| func (r *rowImpl) FieldNames() []string { | |||
| names := make([]string, len(r.offsets)) | |||
| var names []string | |||
There was a problem hiding this comment.
can you fix this line to pickup the latest master changes that pre-allocates please?
There was a problem hiding this comment.
thanks a lot, that is the best solution, I was confused how to do it 🙏🏽 🙏🏽 🙏🏽 🙏🏽 🙏🏽
fixing ...
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#75 shows that
Rowtype has a bug.I added tests to the
Rowtypes.Why are the changes needed?
To guarantee bug free implementation of
Rowtype.Does this PR introduce any user-facing change?
No
How was this patch tested?
The PR adds unit-tests for the
Rowtype.fixes #76
Signed-off-by: Mustafa Elbehery melbeher@redhat.com