[WIP][SPARK-53924] Reload DSv2 tables in views created using plans on each view access #52876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… each view access
aokolnychyi
force-pushed
the
spark-53924
branch
from
f002dd1 to
ccd330c
Compare
cloud-fan
reviewed
Nov 4, 2025
| extends LeafNode with MultiInstanceRelation with NamedRelation { | ||
|
|
||
| override def name: String = { | ||
| s"${catalog.name()}.${identifier.quoted}" |
Contributor
There was a problem hiding this comment.
let's follow DataSourceV2RelationBase or create a base trait/util function
override def name: String = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
(catalog, identifier) match {
case (Some(cat), Some(ident)) => s"${quoteIfNeeded(cat.name())}.${ident.quoted}"
case _ => table.name()
}
}
cloud-fan
reviewed
Nov 4, 2025
|
|
||
| object TableReference { | ||
|
|
||
| case class TableInfo(columns: Seq[Column]) |
Contributor
There was a problem hiding this comment.
shall we just use StructType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes Spark reload DSv2 tables in views created using plans on each view access.
Why are the changes needed?
The current problem is that the view definition in the session catalog captures the analyzed plan that references
Table(that is supposed to pin the version). If a connector doesn’t have an internal cache and produces a newTableobject on each load, the table referenced in the view will become orphan and there will be no way to refresh it unless thatTableinstance auto refreshes on each scan (super dangerous).Does this PR introduce any user-facing change?
Yes, but it restores the correct behavior without requiring hacks in connectors.
How was this patch tested?
TBD.
Was this patch authored or co-authored using generative AI tooling?
No.