chore: use playwright to install browsers #30000
Conversation
Dockerfile
Outdated
| RUN apt-get update -qq \ | ||
| && apt-get install -yqq --no-install-recommends wget bzip2 \ | ||
| && wget -q https://github.com/mozilla/geckodriver/releases/download/${GECKODRIVER_VERSION}/geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz -O - | tar xfz - -C /usr/local/bin \ | ||
| # Install Firefox | ||
| && wget -q https://download-installer.cdn.mozilla.net/pub/firefox/releases/${FIREFOX_VERSION}/linux-x86_64/en-US/firefox-${FIREFOX_VERSION}.tar.bz2 -O - | tar xfj - -C /opt \ | ||
| && ln -s /opt/firefox/firefox /usr/local/bin/firefox \ | ||
| && apt-get autoremove -yqq --purge wget bzip2 && rm -rf /var/[log,tmp]/* /tmp/* /var/lib/apt/lists/* | ||
| # Cache everything for dev purposes... | ||
| RUN playwright install chromium --with-deps | ||
| RUN playwright install firefox --with-deps |
There was a problem hiding this comment.
I'm curious, does with work with multiarch builds? I'm assuming the chromium and firefox binaries are different on x86_64 and arm64. It seems previously we were only installing the x86_64 versions.
There was a problem hiding this comment.
@mistercrunch According to the docs, playwright installs the browsers in some local directory, not in usr/local/bin. We can change that with PLAYWRIGHT_BROWSERS_PATH env variable
There was a problem hiding this comment.
There was a problem hiding this comment.
I think cypress installs its own chromium binary. A proper way to test it would be to run a report
|
I meant to write that I haven't tested this and was looking to comment ask for help or instructions as to how to test this. |
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
4f97538
to
73aa425
Compare
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
6e25c74
to
019cd50
Compare
mistercrunch
requested review from
geido,
eschutho,
betodealmeida,
nytai,
craig-rueda,
john-bodley and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
playwright-in-docker
branch
from
a5e30ac
to
52a6d84
Compare
github-actions
bot
removed
the
github_actions
github-actions
bot
added
the
github_actions
Seems we use playwright to install chromium in some places, but not consistently for chromium and firefox. This makes for confusing/fragile stuff in the Dockerfile. Here I'm just using playwright consistently and in
the docs. Note that this bloats the dev/ci images with BOTH browsers, but people should really just build on top of lean and add their browsers and database drivers from there. We may want to have a single primary browse
r we support and just keep that one in our Dockerfile