Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trino,presto): add missing time grains #30926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

villebro
Copy link
Member

SUMMARY

The PrestoBaseEngineSpec that's used by the Presto and Trino specs is missing some intermediate second, minute and hour time grains. This adds those + unit tests on the actual spec implementations to protect against regressions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

A Trino chart using the new 5 minute time grain:
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added data:connect:presto Related to Presto data:connect:trino Related to Trino labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (76d897e) to head (ab8149c).
Report is 968 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30926       +/-   ##
===========================================
+ Coverage   60.48%   83.85%   +23.36%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38959    -37277     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32669    -13445     
+ Misses      28017     6290    -21727     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.82% <ø> (-0.35%) ⬇️
javascript ?
mysql 76.72% <ø> (?)
postgres 76.81% <ø> (?)
presto 53.30% <ø> (-0.51%) ⬇️
python 83.85% <ø> (+20.36%) ⬆️
sqlite 76.28% <ø> (?)
unit 60.82% <ø> (+3.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

LGTM, put pinging some folks that probably know Trino better than me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:presto Related to Presto data:connect:trino Related to Trino size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants