feat(trino,presto): add missing time grains #30926
Open
+135
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
PrestoBaseEngineSpec
that's used by the Presto and Trino specs is missing some intermediate second, minute and hour time grains. This adds those + unit tests on the actual spec implementations to protect against regressions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
A Trino chart using the new 5 minute time grain:
ADDITIONAL INFORMATION