Skip to content

fix(antd): Invalid dashed border in tertiary button#33291

Merged
michael-s-molina merged 1 commit intoapache:5.0from
justinpark:fix--invalid-dash-style-on-tertiary-button
Apr 30, 2025
Merged

fix(antd): Invalid dashed border in tertiary button#33291
michael-s-molina merged 1 commit intoapache:5.0from
justinpark:fix--invalid-dash-style-on-tertiary-button

Conversation

@justinpark
Copy link
Member

SUMMARY

During the migration process of Ant Design 5 (antd5) buttons here, the border style of the tertiary button was incorrectly applied as dashed, which differs from the intended design.

suggested actual
image Screenshot 2025-04-29 at 3 33 25 PM

Although this issue was resolved on the current master branch with PR #31972, the fix was not included in the 5.0 release. To address this, this commit applies this correction.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before After
Screenshot 2025-04-29 at 3 33 25 PM Screenshot 2025-04-29 at 3 31 47 PM

TESTING INSTRUCTIONS

Go to a chart explore and then check the menu action button

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Apr 29, 2025
@justinpark justinpark requested a review from rusackas April 29, 2025 22:49
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/components/Button/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 692d47c into apache:5.0 Apr 30, 2025
52 of 53 checks passed
@michael-s-molina michael-s-molina added v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch and removed v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants