Skip to content

Conversation

@ethan-l-geotab
Copy link
Contributor

SUMMARY

This commit implements the version changes proposed in GitHub issue #36145 (SIP-192) to create a way to save a dashboard/chart/dataset state.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

I have a few recordings in the comment sections of the SIP going over how it works.

TESTING INSTRUCTIONS

  1. Save the state of the asset (i'm just going to call them dashboards for now)
image 2. Make changes to the dashboard, add charts, remove charts, change the title 3. Restore the dashboard 4. Check to see if it's actually reverted.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-192] Labeled Version History + Restore #36145
  • Required feature flags:
    VERSION_CONTROL_ENABLED = True
    VERSION_RETENTION_LIMIT = 10
  • Changes UI: Properties modal has a new button and modal with the version history info
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added risk:db-migration PRs that require a DB migration api Related to the REST API labels Dec 4, 2025
@ethan-l-geotab ethan-l-geotab changed the title feat(SIP-68): Labeled Version History + Restore feat(SIP-192): Labeled Version History + Restore Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 39.90385% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.85%. Comparing base (92986c2) to head (6e9f029).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
superset/version_control/api.py 30.28% 122 Missing ⚠️
superset/models/version_history.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #36424       +/-   ##
===========================================
+ Coverage        0   67.85%   +67.85%     
===========================================
  Files           0      636      +636     
  Lines           0    46946    +46946     
  Branches        0     5100     +5100     
===========================================
+ Hits            0    31853    +31853     
- Misses          0    13826    +13826     
- Partials        0     1267     +1267     
Flag Coverage Δ
hive 43.69% <39.90%> (?)
mysql 66.91% <39.90%> (?)
postgres 66.96% <39.90%> (?)
presto 47.32% <39.90%> (?)
python 67.81% <39.90%> (?)
sqlite 66.67% <39.90%> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API review:draft risk:db-migration PRs that require a DB migration size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants