Skip to content

Conversation

@rusackas
Copy link
Member

@rusackas rusackas commented Dec 4, 2025

User description

Summary

This PR removes the luxon date/time library which is not used anywhere in the Superset frontend codebase.

Analysis

Using dependency analysis tooling, I verified that:

  • Zero imports: No imports of luxon found in any source files (src/, packages/, plugins/)
  • No transitive dependencies: Not required by any other packages
  • No build/config usage: Not referenced in webpack, babel, or other configuration files
  • Not in scripts: Not used in any npm scripts

Changes

  • Removed luxon (^3.7.1) from package.json dependencies
  • Updated package-lock.json accordingly

Impact

  • Bundle size reduction: Luxon is approximately 73KB minified
  • Reduced maintenance: One less dependency to track and update
  • No functionality changes: The library was completely unused

Testing

  • Verified no imports exist: rg "from ['\"]luxon|import.*luxon|require.*luxon"
  • Frontend builds successfully
  • No TypeScript or linting errors

Context

Luxon appears to have been added but never used, possibly considered as an alternative to existing date libraries (dayjs, moment) but not adopted. The codebase primarily uses dayjs for date/time operations.

🤖 Generated with Claude Code


CodeAnt-AI Description

Remove unused luxon dependency from frontend

What Changed

  • Removed the luxon dependency from superset-frontend package.json and package-lock.json so it is no longer installed with the frontend
  • There are no imports of luxon and no user-visible functionality changes after this removal
  • Reduces the frontend dependency surface and bundle contents

Impact

✅ Lower frontend bundle size (~73KB removed)
✅ Fewer dependencies to track and update
✅ Shorter install time for frontend developers

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

The luxon date/time library was listed as a direct dependency but is never
imported or used anywhere in the codebase. Analysis shows:

- Zero imports of luxon in src/, packages/, or plugins/
- Not required by any other packages as a peer dependency
- Not referenced in any build or configuration files
- Likely superseded by other date libraries already in use (dayjs, moment)

Removing this unused dependency reduces bundle size and maintenance burden.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codeant-ai-for-open-source
Copy link

CodeAnt AI is reviewing your PR.

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Dec 4, 2025

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Dec 4, 2025
@codeant-ai-for-open-source
Copy link

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies:npm preset-io size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant