chore(deps): Remove unused luxon dependency #36430
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Summary
This PR removes the
luxondate/time library which is not used anywhere in the Superset frontend codebase.Analysis
Using dependency analysis tooling, I verified that:
luxonfound in any source files (src/, packages/, plugins/)Changes
luxon(^3.7.1) from package.json dependenciesImpact
Testing
rg "from ['\"]luxon|import.*luxon|require.*luxon"Context
Luxon appears to have been added but never used, possibly considered as an alternative to existing date libraries (dayjs, moment) but not adopted. The codebase primarily uses dayjs for date/time operations.
🤖 Generated with Claude Code
CodeAnt-AI Description
Remove unused luxon dependency from frontend
What Changed
Impact
✅ Lower frontend bundle size (~73KB removed)✅ Fewer dependencies to track and update✅ Shorter install time for frontend developers💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.