Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.21.2 #7831

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update Go version to 1.21.2 #7831

merged 1 commit into from
Oct 6, 2023

Conversation

asf-ci-trafficcontrol
Copy link
Contributor

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.21.2 and updates the golang.org/x/ dependencies.

See the Go 1.21.2 release notes:

go1.21.2 (released 2023-10-05) includes one security fixes to the cmd/go package, as well as bug fixes to the compiler, the go command, the linker, the runtime, and the runtime/metrics package. See the Go 1.21.2 milestone on our issue tracker for details.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.21, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #7831 (50163ba) into master (1c4bcb5) will decrease coverage by 36.71%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7831       +/-   ##
=============================================
- Coverage     65.65%   28.95%   -36.71%     
  Complexity       98       98               
=============================================
  Files           323      602      +279     
  Lines         12836    77415    +64579     
  Branches        970       90      -880     
=============================================
+ Hits           8427    22412    +13985     
- Misses         4050    52904    +48854     
- Partials        359     2099     +1740     
Flag Coverage Δ
golib_unit 53.86% <ø> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.91% <ø> (?)
traffic_monitor_unit 26.44% <ø> (?)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.63% <ø> (?)
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (?)
unit_tests 25.78% <ø> (-48.60%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 516 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman merged commit 57486ef into master Oct 6, 2023
38 checks passed
@zrhoffman zrhoffman deleted the go-1.21.2 branch October 6, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants