Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken deliveryservice_requests query parameter #7893

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

ericholguin
Copy link
Contributor

This PR fixes an issue where deliveryservice_requests query parameters are ignored if the xmlId parameter is used, for example:
deliveryservice_requests?xmlId=deliveryService&status=complete will still return other statuses, this issue applies to all other parameters used alongside xmlId but is not the case when they are used alongside each other.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Build TO and verify one can query using all parameters in combination with xmlId

If this is a bugfix, which Traffic Control versions contained the bug?

Unsure

PR submission checklist

@ericholguin ericholguin added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0ebe87) 31.77% compared to head (8d81b3b) 31.80%.
Report is 1 commits behind head on master.

Files Patch % Lines
...fic_ops_golang/deliveryservice/request/requests.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7893      +/-   ##
============================================
+ Coverage     31.77%   31.80%   +0.02%     
  Complexity       98       98              
============================================
  Files           719      719              
  Lines         82819    82819              
  Branches        970      970              
============================================
+ Hits          26318    26341      +23     
+ Misses        54338    54320      -18     
+ Partials       2163     2158       -5     
Flag Coverage Δ
golib_unit 53.84% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <ø> (ø)
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.63% <0.00%> (+0.04%) ⬆️
traffic_portal_v2 74.37% <ø> (+0.05%) ⬆️
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 29.12% <0.00%> (+0.03%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocket8888 ocket8888 merged commit a28af5a into apache:master Jan 6, 2024
43 checks passed
rimashah25 pushed a commit that referenced this pull request Jan 9, 2024
fix where query statement

(cherry picked from commit a28af5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants