Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPv2 Add page title setting when header title is updated #7915

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ocket8888
Copy link
Contributor

Closes #2742

This PR updates navigation in the experimental TPv2 to also update the page title in the browser whenever the page's header title is set.


Which Traffic Control components are affected by this PR?

  • Traffic Portal (experimental v2)

What is the best way to verify this PR?

Make sure the tests pass. To verify manually, go to a bunch of pages and ensure the web page's title always matches the page header's title.

PR submission checklist

  • This PR has tests
  • This PR doesn't need documentation
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adea91d) 28.84% compared to head (4fd7507) 65.65%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7915       +/-   ##
=============================================
+ Coverage     28.84%   65.65%   +36.80%     
  Complexity       98       98               
=============================================
  Files           602      323      -279     
  Lines         77445    12840    -64605     
  Branches         90      970      +880     
=============================================
- Hits          22342     8430    -13912     
+ Misses        53012     4050    -48962     
+ Partials       2091      360     -1731     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.37% <100.00%> (?)
traffic_stats_unit ?
unit_tests 74.37% <100.00%> (+48.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman merged commit cb47ce8 into apache:master Jan 19, 2024
9 checks passed
@ocket8888 ocket8888 deleted the tpv2/page-title branch January 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix Portal webpage title to reflect current 'page'
2 participants