Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ProfileExportResponse struct to remove undocumented alerts field. #7917

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Jan 18, 2024

Closes: #6797


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

curl API GET profiles/{id}/export/ and confirm there is no alerts field in the response

Original Response

{
"profile":{"name":"GLOBAL","description":"Global Traffic Ops profile, DO NOT DELETE","cdn":"ALL","type":"UNK_PROFILE"},
"parameters":[{"config_file":"global","name":"tm.instance_name","value":"Traffic Ops CDN"},{"config_file":"global","name":"tm.toolname","value":"Traffic Ops"},{"config_file":"regex_revalidate.config","name":"maxRevalDurationDays","value":"90"}],
"alerts":null
}

Fixed Response

{
"profile":{"name":"GLOBAL","description":"Global Traffic Ops profile, DO NOT DELETE","cdn":"ALL","type":"UNK_PROFILE"},
"parameters":[{"config_file":"global","name":"tm.instance_name","value":"Traffic Ops CDN"},{"config_file":"global","name":"tm.toolname","value":"Traffic Ops"},{"config_file":"regex_revalidate.config","name":"maxRevalDurationDays","value":"90"}]
}

If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review January 18, 2024 18:15
@rimashah25 rimashah25 added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (258bcfc) 67.60% compared to head (e2609bf) 32.03%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7917       +/-   ##
=============================================
- Coverage     67.60%   32.03%   -35.57%     
  Complexity       98       98               
=============================================
  Files           268      722      +454     
  Lines         10288    82913    +72625     
  Branches        970      970               
=============================================
+ Hits           6955    26560    +19605     
- Misses         3061    54203    +51142     
- Partials        272     2150     +1878     
Flag Coverage Δ
golib_unit 53.85% <ø> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.88% <ø> (?)
traffic_monitor_unit 25.47% <ø> (?)
traffic_ops_integration 69.42% <ø> (-9.47%) ⬇️
traffic_ops_unit 22.08% <ø> (?)
traffic_portal_v2 74.39% <ø> (+0.01%) ⬆️
traffic_stats_unit 10.78% <ø> (?)
unit_tests 29.37% <ø> (-45.00%) ⬇️
v3 57.79% <ø> (?)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocket8888 ocket8888 merged commit a8c0a5d into apache:master Jan 22, 2024
36 checks passed
@rimashah25 rimashah25 deleted the bugfix/profile-export-output branch January 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"alerts" in output of /profiles/{{ID}}/export
2 participants