Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.22.4 #8021

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update Go version to 1.22.4 #8021

merged 2 commits into from
Jun 6, 2024

Conversation

asf-ci-trafficcontrol
Copy link
Contributor

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.22.4 and updates the golang.org/x/ dependencies.

See the Go 1.22.4 release notes:

go1.22.4 (released 2024-06-04) includes security fixes to the archive/zip and net/netip packages, as well as bug fixes to the compiler, the go command, the linker, the runtime, and the os package. See the Go 1.22.4 milestone on our issue tracker for details.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.22, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (ef3fc6a) to head (bf64be5).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8021      +/-   ##
==========================================
+ Coverage   74.36%   78.58%   +4.21%     
==========================================
  Files         121       57      -64     
  Lines        5548     1564    -3984     
  Branches      908        0     -908     
==========================================
- Hits         4126     1229    -2897     
+ Misses       1351      254    -1097     
- Partials       71       81      +10     
Flag Coverage Δ
traffic_ops_integration 78.58% <ø> (?)
traffic_portal_v2 ?
unit_tests ?
v5 78.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman merged commit 45e553a into master Jun 6, 2024
37 checks passed
@zrhoffman zrhoffman deleted the go-1.22.4 branch June 6, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants