Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tomcat to 9.0.91 #8040

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Update Tomcat to 9.0.91 #8040

merged 2 commits into from
Jul 8, 2024

Conversation

zrhoffman
Copy link
Member

This PR

  • Updates the build system, trafficrouter in CDN in a Box for Developers, Traffic Router GitHub Actions, and the the CDN in a Box makefile to get the Tomcat version from .env
  • Updates the Tomcat version in .env to 9.0.90.

Which Traffic Control components are affected by this PR?

  • Build system
  • Traffic Router
  • CDN in a Box
  • Automation - GitHub Actions

What is the best way to verify this PR?

Verify the GitHub Actions pass

PR submission checklist

@zrhoffman zrhoffman added cdn-in-a-box related to the Docker-based CDN-in-a-Box system build related to the build process automation related to automated testing/deployment/packaging etc. dependencies Pull requests that update a dependency file dev-ciab Related to CDN in a Box for Developers java Pull requests that update Java or Java-related code labels Jul 7, 2024
@zrhoffman zrhoffman force-pushed the tomcat-9.0.90 branch 2 times, most recently from 985253e to 3fef177 Compare July 7, 2024 12:20
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.03%. Comparing base (ef3fc6a) to head (3fef177).
Report is 49 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #8040       +/-   ##
=============================================
- Coverage     74.36%   29.03%   -45.34%     
- Complexity        0       98       +98     
=============================================
  Files           121       28       -93     
  Lines          5548      954     -4594     
  Branches        908       90      -818     
=============================================
- Hits           4126      277     -3849     
+ Misses         1351      643      -708     
+ Partials         71       34       -37     
Flag Coverage Δ
traffic_portal_v2 ?
traffic_router_unit 29.03% <ø> (?)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman changed the title Update Tomcat to 9.0.90 Update Tomcat to 9.0.91 Jul 8, 2024
Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrhoffman zrhoffman merged commit e4631e5 into apache:master Jul 8, 2024
16 checks passed
@zrhoffman zrhoffman deleted the tomcat-9.0.90 branch July 9, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to automated testing/deployment/packaging etc. build related to the build process cdn-in-a-box related to the Docker-based CDN-in-a-Box system dependencies Pull requests that update a dependency file dev-ciab Related to CDN in a Box for Developers java Pull requests that update Java or Java-related code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants