Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.23.0 #8061

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update Go version to 1.23.0 #8061

merged 1 commit into from
Aug 20, 2024

Conversation

zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Aug 15, 2024

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.23.0 and updates the golang.org/x/ dependencies.

See the Go 1.23.0 release notes:

The latest Go release, version 1.23, arrives six months after Go 1.22. Most of its changes are in the implementation of the toolchain, runtime, and libraries. As always, the release maintains the Go 1 promise of compatibility. We expect almost all Go programs to continue to compile and run as before.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.23.0, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericholguin ericholguin merged commit 164af08 into apache:master Aug 20, 2024
38 checks passed
@zrhoffman zrhoffman deleted the go-1.23.0 branch August 27, 2024 15:24
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 27, 2024
This should have been a part of PR apache#8061.
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 27, 2024
This should have been a part of PR apache#8061.
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 27, 2024
This should have been a part of PR apache#8061. Without
this change, the Go 1.23 language version is not used.
zrhoffman added a commit that referenced this pull request Sep 3, 2024
Update Go version in go.mod to 1.23.0

This should have been a part of PR #8061. Without
this change, the Go 1.23 language version is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants