Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PUT /deliveryservice_request_comments id #8071

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Improve PUT /deliveryservice_request_comments id #8071

merged 1 commit into from
Sep 3, 2024

Conversation

zrhoffman
Copy link
Member

#8071 improves validation for the id field of the PUT /deliveryservice_request_comments endpoint.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run existing deliveryservice_request_comments tests

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.1

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. labels Sep 3, 2024
kdamichie
kdamichie approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrhoffman zrhoffman merged commit 096b2e2 into apache:master Sep 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdamichie kdamichie kdamichie approved these changes

Assignees
No one assigned
Labels
improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrhoffman @kdamichie