add configuration plugin #3
Conversation
| parser.add_option('--sleep-in-sec', type='int', default=0, | ||
| dest='sleep_in_sec', | ||
| help='Sleep time before ATS start and after ATS stop to allow enough time for async tests') | ||
| parser.add_option('--standalone-ats-port', type='int', default=-1, |
There was a problem hiding this comment.
This will probably need to follow the same server_ports markup that we have in records.config-- since ATS ports have different attributes associated with them (such as ipv4:443 -- https://docs.trafficserver.apache.org/en/latest/reference/configuration/records.config.en.html#proxy-config-http-server-ports)
…g to comply with ATS settings
| #process environment options | ||
| self.sleep_in_sec = 0 | ||
| if hasattr(plugin.conf_plugin, 'args'): | ||
| if plugin.conf_plugin.args.sleep_in_sec: |
There was a problem hiding this comment.
Are both if checks necessary? And if so, can we put them in one line?
|
@cynthiagu23 Few comments left unfixed, once those are taken care of I think we are good to merge :) |
| # Copyright (c) 2004-2006 Zope Corporation and Contributors. | ||
| # All Rights Reserved. | ||
| # | ||
| # This software is subject to the provisions of the Zope Public License, |
There was a problem hiding this comment.
is ZPL compatible with Apache?
There was a problem hiding this comment.
i think all we have to do, is add this notice to the NOTICE file, like we do in ats itself
https://github.com/apache/trafficserver/blob/master/NOTICE
add 3 configurations for the environment: