Skip to content

Fix of use-after-free tunnel_handler_100_continue_ua #12561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix of use-after-free tunnel_handler_100_continue_ua #12561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/proxy/http/HttpSM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3425,9 +3425,9 @@ HttpSM::tunnel_handler_100_continue_ua(int event, HttpTunnelConsumer *c)
_ua.get_entry()->in_tunnel = false;
c->write_success = true;

// remove the buffer reader from the consumer's vc
// Disable any write operation in case there are timeout events.
if (c->vc != nullptr) {
c->vc->do_io_write();
c->vc->do_io_write(nullptr, 0, nullptr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to pass in "this" as the first argument. I've had problems before with state machines getting lost because a terminal event is delivered to a VIO with no continuation to deliver the terminal event to.

}
}

Expand Down