access_control: use Regex instead of pcre #12572
Merged
+36
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
force-pushed
the
access_control_pcre
branch
from
e7aca53 to
1137c70
Compare
bryancall
requested changes
Oct 21, 2025
Updates the access_control plugin to use tsutil Regex instead of pcre.
bneradt
force-pushed
the
access_control_pcre
branch
from
1137c70 to
258fabb
Compare
bryancall
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
✅ APPROVED
Excellent work! This PR successfully migrates the access_control plugin from raw PCRE to tsutil::Regex with proper attention to detail.
Key Strengths:
- ✅ RE_NOTEMPTY flag preserved in all 3 exec() calls (lines 205, 232, 268)
- ✅ Proper error handling with new RE_ERROR_NOMATCH and RE_ERROR_NULL constants
- ✅ Memory safety with std::unique_ptr and RAII
- ✅ Comprehensive testing including new unit tests for error codes
Verification:
- All RE_NOTEMPTY flags present and correct
- Error constants properly mapped and tested
- No linter errors
- Follows same pattern as PR #12576
Risk: LOW 🟢
- Behavioral compatibility maintained
- Good test coverage
- Clean migration strategy
Ready for merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the access_control plugin to use tsutil Regex instead of pcre.