regex_remap: convert from pcre to Regex #12575
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
reviewed
Oct 21, 2025
| // Constants | ||
| static const int OVECCOUNT = 30; // We support $0 - $9 x2 ints, and this needs to be 1.5x that | ||
| static const int MAX_SUBS = 32; // No more than 32 substitution variables in the subst string | ||
| static const int MATCHCOUNT = 15; |
There was a problem hiding this comment.
The match count was 10, is there a reason to increase it to 15?
| { | ||
| char *str; | ||
| int ccount; | ||
| // int ccount; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version removes checks for recursive regex limits. I plan on adding checks to tsutil/Regex