Trafodion 3084 support to create comment on hbase table #1597
Conversation
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2734/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2734/ |
|
@anoopsharma00 Does this look ok ? Looks ok to me and can merge with your +1. |
|
Were testcases added to regressions to test this feature? |
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2761/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2761/ |
|
Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2762/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2762/ |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2769/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2769/ |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2773/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2773/ |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2779/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2779/ |
gdgy
changed the title
There was a problem hiding this comment.
+1 Looks good to me. @anoopsharma00, does this look good to you now?
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2880/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2880/ |
|
Can one of the admins verify this patch? |
|
jenkins, retest |
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2951/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2951/ |
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3203/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/3203/ |
|
|
||
| Lng32 cliRC = cliInterface.executeImmediate(ddl.data()); | ||
| // error code -8102 means the object already register | ||
| if (cliRC < 0 && cliRC != -8102) |
There was a problem hiding this comment.
Since the ddl issued is 'register ...if not registered', an 8102 error will
not be returned if object already exists.
This check should not be done and all errors should be returned.
| retcode = deleteFromTextTable(&cliInterface, | ||
| objUID, | ||
| ComTextType::COM_OBJECT_COMMENT_TEXT, | ||
| 0); |
There was a problem hiding this comment.
if retcode is < 0, it should return -1 indicating an error.
No description provided.