Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-3264] eliminate unneeded function call in Lob-related functions #1782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wenjun-zhu
Copy link
Contributor

in file core/sql/executor/ExExeUtilLoad.cpp, lines like:

	    ex_expr::exp_return_type exprRetCode =	
	      lobTdb().inputExpr_->eval(NULL, 	
					workAtp_);

call function eval(), with first parameter NULL.

Then code in ex_expr::evalClauses() accesses NULL pointer, so the server aborts.

As @sandhyasun said, this invocation is unneeded, so remove these code.

@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3113/

@Traf-Jenkins
Copy link

Can one of the admins verify this patch?

@Traf-Jenkins
Copy link

@sandhyasun
Copy link
Contributor

sandhyasun commented Jan 28, 2019

Did you run all the extract commands and "update lob" commands and ensure this expression eval can be eliminated ? Did executor/TEST130 pass ? And the JDBC LOB tests that are part of regressions ? They go through this code path.

@sandhyasun
Copy link
Contributor

We can merge this in if we get the results on executor/TEST130 and the JDBC lob tests. Please update this PR with the results.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants