Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #385: Allow import of type systems published through SPI #397

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Sep 30, 2024

What's in the PR

  • Added capabilities for the new unified provider
  • Checking if a provider has already been processed when scanning legacy and new providers does not help because they are instantiated freshly on every call to the service provider scanner, so remove that
  • Log different messages when loading through the legacy SPI interfaces and through the new one

How to test manually

  • Try using the new unified SPI

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Added capabilities for the new unified provider
- Checking if a provider has already been processed when scanning legacy and new providers does not help because they are instantiated freshly on every call to the service provider scanner, so remove that
- Log different messages when loading through the legacy SPI interfaces and through the new one
@reckart reckart added the 🦟 Bug Something isn't working label Sep 30, 2024
@reckart reckart added this to the 3.6.0 milestone Sep 30, 2024
@reckart reckart self-assigned this Sep 30, 2024
@reckart reckart merged commit a5a825a into main Sep 30, 2024
3 checks passed
@reckart reckart deleted the bugfix/385-Allow-import-of-type-systems-published-through-SPI branch September 30, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant