Skip to content

Remove dependency on bundled DOM SAX JAXP classes that have been bund… #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elharo wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove dependency on bundled DOM SAX JAXP classes that have been bund… #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c1e9a
Remove dependency on bundled DOM SAX JAXP classes that have been bund…
elharo Mar 1, 2026
ece33cb
comments
elharo Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ Authors:
<property name='parser_version' value='2_12_3'/>

<property name='deprecatedjar.parser' value='xerces.jar'/>
<property name='jar.apis' value='xml-apis.jar'/>
<property name='jar.parser' value='xercesImpl.jar'/>
<property name='jar.samples' value='xercesSamples.jar'/>
<property name='jar.dv' value='xercesDV.jar'/>
Expand Down Expand Up @@ -285,7 +284,7 @@ Authors:
destdir="${build.dest}"
source="${javac.source}"
target="${javac.target}"
classpath="${build.dir}/classes:${tools.dir}/${jar.apis}:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"
classpath="${build.dir}/classes:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"
debug="${debug}"
debuglevel="${debuglevel}"
deprecation="${deprecation}"
Expand Down Expand Up @@ -353,7 +352,7 @@ Authors:
destdir="${build.dest}"
source="${javac.source}"
target="${javac.target}"
classpath="${build.dir}/classes:${tools.dir}/${jar.apis}"
classpath="${build.dir}/classes"
debug="${debug}"
debuglevel="${debuglevel}"
includeAntRuntime="false"
Expand All @@ -373,7 +372,7 @@ Authors:
destdir="${build.dest}"
source="${javac.source}"
target="${javac.target}"
classpath="${tools.dir}/${jar.apis}:${build.dir}/classes:./tools/junit.jar"
classpath="${build.dir}/classes:./tools/junit.jar"
debug="${debug}"
debuglevel="${debuglevel}"
includeAntRuntime="false"
Expand Down Expand Up @@ -747,8 +746,6 @@ Authors:
<!-- =================================================================== -->
<target name="pack-bin" depends="pack-bin-common, jars">
<copy file="${build.dir}/${jar.parser}" tofile="${distbin.dir}/${jar.parser}"/>
<!-- include the xml-commons APIs -->
<copy file="${tools.dir}/${jar.apis}" tofile="${distbin.dir}/${jar.apis}"/>
<!-- include the xml-commons resolver -->
<copy file="${tools.dir}/${jar.resolver}" tofile="${distbin.dir}/${jar.resolver}"/>
<!-- include the Xalan Serializer -->
Expand Down Expand Up @@ -783,11 +780,11 @@ Authors:
<zip zipfile="${build.dir}/deprecated${parser.Name}-bin.${parser.version}.zip"
basedir="${build.dir}"
includes="${parser.shortname}-${parser_version}/**"
excludes="*.class, **/${jar.parser}, **/${jar.apis}"/>
excludes="*.class, **/${jar.parser}"/>
<tar tarfile="${build.dir}/deprecated${parser.Name}-bin.${parser.version}.tar"
basedir="${build.dir}"
includes="${parser.shortname}-${parser_version}/**"
excludes="*.class, **/${jar.parser}, **/${jar.apis}"/>
excludes="*.class, **/${jar.parser}"/>
<gzip zipfile="${build.dir}/deprecated${parser.Name}-bin.${parser.version}.tar.gz"
src="${build.dir}/deprecated${parser.Name}-bin.${parser.version}.tar" />
<!-- as before, let's kill of the ungzip'd tarball! -->
Expand All @@ -797,7 +794,6 @@ Authors:

<target name="test" depends="tests">
<path id="run.classpath">
<pathelement location="${tools.dir}/${jar.apis}"/>
<pathelement location="${tools.dir}/${jar.resolver}"/>
<pathelement location="${tools.dir}/${jar.serializer}"/>
<pathelement location="${tools.dir}/${jar.junit}"/>
Expand Down Expand Up @@ -999,11 +995,9 @@ Authors:
</target>

<!-- =================================================================== -->
<!-- Builds xercesImpl, xml-apis and sample jar files -->
<!-- Builds xercesImpl and sample jar files -->
<!-- =================================================================== -->
<target name="jars" depends="jar, sampjar">
<!-- include the xml-commons APIs -->
<copy file="${tools.dir}/${jar.apis}" tofile="${build.dir}/${jar.apis}"/>
<!-- include the xml-commons resolver -->
<copy file="${tools.dir}/${jar.resolver}" tofile="${build.dir}/${jar.resolver}"/>
<!-- include the Xalan Serializer -->
Expand Down Expand Up @@ -1072,7 +1066,7 @@ Authors:
optimize="${optimize}"
includeAntRuntime="false"
includeJavaRuntime="true"
classpath="${tools.dir}/${jar.apis}:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"/>
classpath="${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"/>
</target>


Expand Down Expand Up @@ -1331,8 +1325,6 @@ Authors:
<!-- Builds xercesImpl (dtd), xml-apis, and sample jars -->
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on this line still says "Builds xercesImpl (dtd), xml-apis, and sample jars" but the xml-apis copy step has been removed from this target. The comment should be updated to remove the reference to xml-apis, for example: "Builds xercesImpl (dtd) and sample jars".

Suggested change
<!-- Builds xercesImpl (dtd), xml-apis, and sample jars -->
<!-- Builds xercesImpl (dtd) and sample jars -->

Copilot uses AI. Check for mistakes.
<!-- =================================================================== -->
<target name="dtdjars" depends="dtdjar, sampjar">
<!-- include the xml-commons APIs -->
<copy file="${tools.dir}/${jar.apis}" tofile="${build.dir}/${jar.apis}"/>
<!-- include the xml-commons resolver -->
<copy file="${tools.dir}/${jar.resolver}" tofile="${build.dir}/${jar.resolver}"/>
<!-- include the Xalan Serializer -->
Expand Down Expand Up @@ -1365,7 +1357,7 @@ Authors:
destdir="${build.dest}"
source="${javac.source}"
target="${javac.target}"
classpath="${build.dir}/classes:${tools.dir}/${jar.apis}"
classpath="${build.dir}/classes"
debug="${debug}"
debuglevel="${debuglevel}"
deprecation="${deprecation}"
Expand Down Expand Up @@ -1467,7 +1459,6 @@ Authors:
<arg value="${parser.version}"/>
<classpath>
<pathelement location="tests/conformance/utilities.jar"/>
<pathelement location="${build.dir}/${jar.apis}"/>
<pathelement location="${build.dir}/${jar.parser}"/>
</classpath>
</java>
Expand All @@ -1480,7 +1471,6 @@ Authors:
<arg value="${parser.version}"/>
<classpath>
<pathelement location="tests/conformance/utilities.jar"/>
<pathelement location="${build.dir}/${jar.apis}"/>
<pathelement location="${build.dir}/${jar.parser}"/>
</classpath>
</java>
Expand Down Expand Up @@ -1516,7 +1506,7 @@ Authors:
destdir="${build.dest}"
source="${javac.source}"
target="${javac.target}"
classpath="${build.dir}/classes:${tools.dir}/${jar.apis}:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"
classpath="${build.dir}/classes:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"
debug="${debug}"
debuglevel="${debuglevel}"
deprecation="${deprecation}"
Expand Down Expand Up @@ -1564,11 +1554,9 @@ Authors:
</target>

<!-- =================================================================== -->
<!-- Builds xercesImpl, xml-apis and sample jars with Schema 1.1 support -->
<!-- Builds xercesImpl and sample jars with Schema 1.1 support -->
<!-- =================================================================== -->
<target name="jars-schema11" depends="jar-schema11, sampjar">
<!-- include the xml-commons APIs -->
<copy file="${tools.dir}/${jar.apis}" tofile="${build.dir}/${jar.apis}"/>
<!-- include the xml-commons resolver -->
<copy file="${tools.dir}/${jar.resolver}" tofile="${build.dir}/${jar.resolver}"/>
<!-- include the Xalan Serializer -->
Expand Down
Loading