[ZEPPELIN-6150] zeppelin.sh shall respect HADOOP_HOME to find hadoop command
#4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Reamer, could you please take a look at this? |
pan3793
force-pushed
the
ZEPPELIN-6150
branch
from
df99b47
to
6c6dc76
Compare
Reamer
reviewed
Nov 15, 2024
Co-authored-by: Philipp Dallig <philipp.dallig@gmail.com>
Reamer
approved these changes
Nov 15, 2024
|
MS Windows testing failure is irrelevant, thanks, merging to master/0.12 |
pan3793
added a commit
that referenced
this pull request
Nov 15, 2024
…op` command ### What is this PR for? Obviously, `*_HOME` should be respected if they are present, otherwise fallback to find the command in `PATH`. ### What type of PR is it? Improvement ### What is the Jira issue? ZEPPELIN-6150 ### How should this be tested? Manually tested on a dev env, there are multiple Hadoop clients installed in one machine, and `hadoop` is not available in `PATH`, now I can set `HADOOP_HOME` to allow Zeppelin start. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? no * Is there breaking changes for older versions? might be * Does this needs documentation? no Closes #4899 from pan3793/ZEPPELIN-6150. Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit d21e362) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Obviously,
*_HOMEshould be respected if they are present, otherwise fallback to find the command inPATH.What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-6150
How should this be tested?
Manually tested on a dev env, there are multiple Hadoop clients installed in one machine, and
hadoopis not available inPATH, now I can setHADOOP_HOMEto allow Zeppelin start.Screenshots (if appropriate)
Questions: