Skip to content

Merge v4 progress #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Autocomplete, TextField } from '@mui/material';

import type { Weapon as WeaponDefinition } from '../../definitions/types/weapon/weapon';
import { weaponDefinitions } from '../../definitions/weapons/weapon-definitions';
import type { WeaponDefinition } from '../../models/weapon-definition';

export interface WeaponDefinitionSelectorProps {
selectedWeaponDefinition: WeaponDefinition | undefined;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
import type {
FusionWeaponElementalType,
WeaponElementalType,
} from '../definitions/elemental-type';
import type { WeaponName } from '../definitions/weapons/weapon-definitions';
import { weaponDefinitions } from '../definitions/weapons/weapon-definitions';
import type { WeaponType } from '../definitions/weapons/weapon-type';
import type {
DischargeAttackDefinition,
DodgeAttackDefinition,
NormalAttackDefinition,
SkillAttackDefinition,
} from './v4/weapon/weapon-attack-definition';
import type { WeaponBuffDefinition } from './v4/weapon/weapon-buff-definition';
import type { WeaponResourceDefinition } from './v4/weapon/weapon-resource-definition';
} from '../../../models/v4/weapon/weapon-attack-definition';
import type { WeaponBuffDefinition } from '../../../models/v4/weapon/weapon-buff-definition';
import type { WeaponResourceDefinition } from '../../../models/v4/weapon/weapon-resource-definition';
import type {
WeaponAttackPercentBuffDefinition,
WeaponCritDamageBuffDefinition,
WeaponCritRateBuffDefinition,
} from './weapon-buff-definition';
} from '../../../models/weapon-buff-definition';
import type {
FusionWeaponElementalType,
WeaponElementalType,
} from '../../elemental-type';
import type { WeaponName } from '../../weapons/weapon-definitions';
import { weaponDefinitions } from '../../weapons/weapon-definitions';
import type { WeaponType } from '../../weapons/weapon-type';

export interface WeaponDefinition {
export interface Weapon {
id: WeaponName;
displayName: string;
/** Optional. The weapon's icon will be inferred from the id if not provided */
Expand Down Expand Up @@ -51,6 +51,6 @@ export interface WeaponDefinition {
resources: WeaponResourceDefinition[];
}

export function getWeaponDefinition(id: WeaponName): WeaponDefinition {
export function getWeaponDefinition(id: WeaponName): Weapon {
return weaponDefinitions.byId[id];
}
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/alyss.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const alyss = {
id: 'Alyss',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const alyss = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/anka.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const anka = {
id: 'Anka',
Expand Down Expand Up @@ -43,4 +43,4 @@ export const anka = {
discharges: [],
buffs: [],
resources: [],
} as const satisfies WeaponDefinition;
} as const satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/annabella.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const annabella = {
id: 'Annabella',
Expand Down Expand Up @@ -53,4 +53,4 @@ export const annabella = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/asuka.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const asuka = {
id: 'Asuka',
Expand Down Expand Up @@ -43,4 +43,4 @@ export const asuka = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/brevey.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const brevey = {
id: 'Brevey',
Expand Down Expand Up @@ -63,4 +63,4 @@ export const brevey = {
'Used to track the amount of damage accumulated, one unit is 1 times the total ATK',
},
],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/claudia.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const claudia = {
id: 'Claudia',
Expand Down Expand Up @@ -31,4 +31,4 @@ export const claudia = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/cobalt-b.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const cobaltB = {
id: 'Cobalt-B',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const cobaltB = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/cocoritter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const cocoritter = {
id: 'Cocoritter',
Expand Down Expand Up @@ -43,4 +43,4 @@ export const cocoritter = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/crow.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const crow = {
id: 'Crow',
Expand All @@ -17,4 +17,4 @@ export const crow = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/fei-se.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const feiSe = {
id: 'Fei Se',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const feiSe = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/fenrir.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const fenrir = {
id: 'Fenrir',
Expand Down Expand Up @@ -53,4 +53,4 @@ export const fenrir = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/fiona.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const fiona = {
id: 'Fiona',
Expand Down Expand Up @@ -42,4 +42,4 @@ export const fiona = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/frigg.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const frigg = {
id: 'Frigg',
Expand Down Expand Up @@ -52,4 +52,4 @@ export const frigg = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/gnonno.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const gnonno = {
id: 'Gnonno',
Expand Down Expand Up @@ -31,4 +31,4 @@ export const gnonno = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/huma.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const huma = {
id: 'Huma',
Expand All @@ -17,4 +17,4 @@ export const huma = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/icarus.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const icarus = {
id: 'Icarus',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const icarus = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/ji-yu.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const jiYu = {
id: 'Ji Yu',
Expand Down Expand Up @@ -43,4 +43,4 @@ export const jiYu = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/king.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const king = {
id: 'King',
Expand All @@ -17,4 +17,4 @@ export const king = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/lan.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const lan = {
id: 'Lan',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const lan = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/lin.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const lin = {
id: 'Lin',
Expand Down Expand Up @@ -65,4 +65,4 @@ export const lin = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/ling-han.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const lingHan = {
id: 'Ling Han',
Expand Down Expand Up @@ -41,4 +41,4 @@ export const lingHan = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/liu-huo.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const liuHuo = {
id: 'Liu Huo',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const liuHuo = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/lyra.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const lyra = {
id: 'Lyra',
Expand Down Expand Up @@ -44,4 +44,4 @@ export const lyra = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/meryl.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const meryl = {
id: 'Meryl',
Expand All @@ -17,4 +17,4 @@ export const meryl = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/mimi.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const mimi = {
id: 'Huang (Mimi)',
Expand Down Expand Up @@ -30,4 +30,4 @@ export const mimi = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/ming-jing.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const mingJing = {
id: 'Ming Jing',
Expand Down Expand Up @@ -43,4 +43,4 @@ export const mingJing = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/nan-yin.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const nanYin = {
id: 'Nan Yin',
Expand Down Expand Up @@ -36,4 +36,4 @@ export const nanYin = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
4 changes: 2 additions & 2 deletions src/definitions/weapons/definitions/nemesis.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { WeaponDefinition } from '../../../models/weapon-definition';
import type { Weapon } from '../../types/weapon/weapon';

export const nemesis = {
id: 'Nemesis',
Expand Down Expand Up @@ -65,4 +65,4 @@ export const nemesis = {
discharges: [],
buffs: [],
resources: [],
} satisfies WeaponDefinition;
} satisfies Weapon;
Loading
Loading