-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for ZnTrack v0.8.0 release #356
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
apax/nodes/md.py
Outdated
@@ -38,7 +36,7 @@ class ApaxJaxMD(zntrack.Node): | |||
data_id: int = zntrack.params(-1) | |||
|
|||
model: ApaxBase = zntrack.deps() | |||
repeat = zntrack.params(None) | |||
repeat: typing.Optional[bool] = zntrack.params(None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this bee optional[list[int]]?
apax/nodes/model.py
Outdated
@@ -42,11 +43,11 @@ class Apax(ApaxBase): | |||
|
|||
data: list = zntrack.deps() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this would also be list[ase.atoms]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I had some minor comments but otherwise it looks great!
for more information, see https://pre-commit.ci
Works like
Training a Model within apax
and loading it from rev should now work just fine