Switch bootstrap method from ng-app to angular.bootstrap() #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to angular.bootstrap() enables multiple AngularJS apps to live on single HTML document. Previously used ng-app directive only works for single app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to angular.bootstrap() enables multiple AngularJS apps to live on single HTML document. Previously used ng-app directive only works for single app.
This isn't as clean as the ng-app bootstrap method, but considering that other admin tools might also use AngularJS, this is definitely the preferred solution. This came up while trying to implement UserGroups and FieldtypePoll on same site. Based on some Googling, manually calling angular.bootstrap() for each app seems to be the only way to make this work.
@apeisa @niklaka Unless you see any potential issues with this, I'm going to merge this into master soon. This is working fine for me on one test site, but that's the extent of testing I've done so far.
Note to @apeisa: FieldtypePoll required a similar change. I might send a pull request for that later :)