Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPM build script for RPM and DEB #279

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Conversation

RedProkofiev
Copy link
Contributor

@RedProkofiev RedProkofiev commented Nov 2, 2023

Resolves #123
Resolves GT-253

This PR adds a build script that supersedes ssm-build-rpm.sh and ssm-build-deb.sh by adapting the FPM calls made in the original Debian script and adding configurable parameters. It works with Python 2.7 and >= 3.6, and requires FPM 1.14.2 and a version of Ruby at or above 2.7, as well as specifically Setuptools==51.3.3. It allows a version to be specified to pull from the repository and be setup.

Usage: ./ssm-build-dual.sh [options] (deb | rpm) <version> <iteration> <python_root_dir>

Currently, this should work for all future versions and all the past RPM versions: Debian, it doesn't work for before the coming 3.4.0 update due to CHANGELOG having a title.

@RedProkofiev
Copy link
Contributor Author

Build script is here! Finally working on EL8 and Debian systems, with service setup.

@RedProkofiev RedProkofiev marked this pull request as ready for review January 17, 2024 11:06
@RedProkofiev RedProkofiev requested a review from a team as a code owner January 17, 2024 11:06
@RedProkofiev
Copy link
Contributor Author

For some reason there's still a merge conflict - was the patch reverted? or is this due to my dev branch not being fast forwarded?

@tofu-rocketry tofu-rocketry self-assigned this Jan 17, 2024
@tofu-rocketry
Copy link
Member

For some reason there's still a merge conflict - was the patch reverted? or is this due to my dev branch not being fast forwarded?

That'll be because we merged the change to the CHANGELOG into the dev branch separately. I'll help you sort that out towards the end of the week.

Could you have a look at the code quality checks and see if you can improve that?

@RedProkofiev RedProkofiev changed the title Nick 123 FPM build script for SSM and SSM-Service for RPM and DEB Jan 17, 2024
@RedProkofiev RedProkofiev changed the title FPM build script for SSM and SSM-Service for RPM and DEB FPM build script for RPM and DEB Jan 17, 2024
@RedProkofiev RedProkofiev force-pushed the nick-123 branch 3 times, most recently from 4b5260b to fb8fd84 Compare January 18, 2024 10:29
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tofu-rocketry tofu-rocketry force-pushed the nick-123 branch 2 times, most recently from 0d2ef47 to 0da5063 Compare February 6, 2024 15:15
- Adds cryptography as a dependency before pyopenssl
- Modified pyopenssl to lower case to satisfy pip call
@tofu-rocketry tofu-rocketry merged commit 9323a4a into apel:dev Feb 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build and test on CentOS 8
2 participants