Remove default host and tidy comments#382
Merged
tofu-rocketry merged 1 commit intoapel:devfrom Nov 29, 2024
Merged
Conversation
tofu-rocketry
force-pushed
the
sender-config
branch
from
638b8bf to
28a8f5d
Compare
Member
|
-> 'port' is only used for STOMP sending. Just one thing, Is this intentional, Adrian. If so, We might need to make a note to update |
Member
Author
Oh, I misread. We only use AMS sending in production, so no need to change the AQ config. |
We don't want people accidentally sending to the production host, but we also don't want people to accidentally send to the devel host if not intended. So remove the default host and add the list of hosts to a comment, explaining the purpose of each. Also uncomment the port option and clarify its usage. It does nothing for AMS sending, so might as well leave it uncommented.
tofu-rocketry
force-pushed
the
sender-config
branch
from
28a8f5d to
3edb90e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #375 in a slightly different way to suggested.
We don't want people accidentally sending to the production host, but we also don't want people to accidentally send to the devel host if not intended. So remove the default host and add the list of hosts to a comment, explaining the purpose of each.
Also uncomment the port option and clarify its usage. It does nothing for AMS sending, so might as well leave it uncommented.