Skip to content

Fix nojekyll missing and incorrect base url#26

Merged
thirstyape merged 1 commit intomasterfrom
25-fix-gh-pages-deployment
Feb 26, 2026
Merged

Fix nojekyll missing and incorrect base url#26
thirstyape merged 1 commit intomasterfrom
25-fix-gh-pages-deployment

Conversation

@thirstyape
Copy link
Contributor

No description provided.

@thirstyape thirstyape self-assigned this Feb 26, 2026
Copilot AI review requested due to automatic review settings February 26, 2026 17:05
@thirstyape thirstyape linked an issue Feb 26, 2026 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix deployment issues related to the .nojekyll file and base href configuration for GitHub Pages deployment of a Blazor WASM application. However, the implementation introduces redundant operations and deviates from standard practices.

Changes:

  • Modified the .nojekyll file creation to write content to it instead of creating an empty file
  • Added a new step to rewrite the base href in index.html using sed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thirstyape thirstyape merged commit 257bc1a into master Feb 26, 2026
10 of 11 checks passed
@thirstyape thirstyape deleted the 25-fix-gh-pages-deployment branch February 26, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix GH Pages deployment

2 participants